Skip to content

London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | jq#356

Open
jamallaqdiem wants to merge 5 commits into
CodeYourFuture:mainfrom
jamallaqdiem:jq
Open

London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | jq#356
jamallaqdiem wants to merge 5 commits into
CodeYourFuture:mainfrom
jamallaqdiem:jq

Conversation

@jamallaqdiem
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

Completing jq exercises.

@jamallaqdiem jamallaqdiem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Mar 12, 2026
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution works great. I just have a question.

Comment thread jq/script-11.sh Outdated
# The input for this script is the scores.json file.
# TODO: Write a command to output the total of adding together all scores from all games from all players.
# Your output should be exactly the number 164.
jq -r ' [.[] | (.scores[])] | add' scores.json No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce the parentheses?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for reviewing, the reason behind using the parenthesis is to mathematical grouping habit which is wrong and redundant in this case, it will not break the code, but it works without it.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 9, 2026
@jamallaqdiem jamallaqdiem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 13, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 13, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 13, 2026

All good.

Note: The checkboxes in the PR description are not properly formatted in Markdown syntax. For more info, please refer to:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants