Skip to content

London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls#1254

Open
Temceo wants to merge 5 commits into
CodeYourFuture:mainfrom
Temceo:sprint1_form_controls
Open

London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls#1254
Temceo wants to merge 5 commits into
CodeYourFuture:mainfrom
Temceo:sprint1_form_controls

Conversation

@Temceo
Copy link
Copy Markdown

@Temceo Temceo commented May 12, 2026

Learners, PR Template

Self checklist

  • [X ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • [ X] I have tested my changes
  • [ X] My changes follow the style guide

Changelist

Briefly explain your PR.
I have forked the original form controls and made updates on a branch (sprint1_control_forms).
I have add a new form using semantic html with labels and controls for entry of name, email, colour and sizes

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit eb46639
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0412e45d56d40008c91cec
😎 Deploy Preview https://deploy-preview-1254--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Temceo Temceo added the Module-Onboarding The name of the module. label May 12, 2026
@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Temceo Temceo marked this pull request as draft May 12, 2026 08:35
@Sambuxc
Copy link
Copy Markdown

Sambuxc commented May 12, 2026

If you're having difficulty with the automated PR checks please reach out in slack.
Make sure to add all required fields in the PR description that follow this format:

  • All self checklist items are ticked (with a [x]) - watch out for stray spacing
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

@Temceo Temceo marked this pull request as ready for review May 12, 2026 20:11
@Sambuxc Sambuxc added the Complete Volunteer to add when work is complete and all review comments have been addressed. label May 13, 2026
@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Sambuxc Sambuxc added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels May 13, 2026
@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 13, 2026
@Sambuxc Sambuxc added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 13, 2026
@github-actions
Copy link
Copy Markdown

Your PR description is incomplete.

You filled out a template (that starts "Learners, PR Template") when you created this PR - you can see it at the top of this page.

Make sure to fill in all fields in the template.

Please ensure:

  • All self checklist items are ticked (with a [x])
  • The "Changelist" section is filled with details of what your PR does.
  • The "Questions" section is either filled in (if you have questions) or is removed (if you don't).

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants