Skip to content

London | May 2026 | Giorgi Natriashvili | Sprint 1 | Form Controls#1250

Open
Giontr wants to merge 3 commits into
CodeYourFuture:mainfrom
Giontr:Form-Controls
Open

London | May 2026 | Giorgi Natriashvili | Sprint 1 | Form Controls#1250
Giontr wants to merge 3 commits into
CodeYourFuture:mainfrom
Giontr:Form-Controls

Conversation

@Giontr
Copy link
Copy Markdown

@Giontr Giontr commented May 11, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I built simple forms for verifying order for client, after change styles in CSS for "radio" buttons to meet accessibility criteria, however realized that whole form needed some margin for spacing, which was changed afterwards.

Finally I met accessibility criteria 100.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 01c70a5
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a018b4f6dac870008606691
😎 Deploy Preview https://deploy-preview-1250--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Giontr Giontr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 11, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 11, 2026
@Giontr Giontr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 11, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 11, 2026
@Giontr Giontr added 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 11, 2026
Comment thread Form-Controls/index.html
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<h1>Verify your order </h1>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for next time, watch out for stray spacing.
the h1 element has a single space at the start of the line

@Sambuxc Sambuxc added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants