Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe#1241
Open
Monsur0001 wants to merge 5 commits into
Open
Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe#1241Monsur0001 wants to merge 5 commits into
Monsur0001 wants to merge 5 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
Needs Review
illicitonion
changed the title
Sambuxc
added
the
Review in progress
Sambuxc
suggested changes
May 12, 2026
| <p class="center">Practicing commits in Git</p> | ||
| </header> | ||
| <main> | ||
| <div class="container"> |
There was a problem hiding this comment.
Is there a semantic tag you could use instead here?
| </main> | ||
| </div> | ||
|
|
||
| <div class="article-row"> |
There was a problem hiding this comment.
Is there a semantic tag you could use instead here?
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> |
There was a problem hiding this comment.
Your page head should include a title and description
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
| position: fixed; |
There was a problem hiding this comment.
Why did you decide to remove the fixed position?
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> |
There was a problem hiding this comment.
How have you linked your html to the style.css file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Wireframe tasks completed.