London | 26 ITP May | Sayeed Hussain | Sprint 1 | Form Control#1230
London | 26 ITP May | Sayeed Hussain | Sprint 1 | Form Control#1230sayeedhussain01 wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sayeedhussain01
added
Needs Review
Sambuxc
added
Review in progress
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
|
|
||
| <body class="font"> |
There was a problem hiding this comment.
Do you need this class font to its styles to the body element?
There was a problem hiding this comment.
No, it is not strictly necessary for body element ,but I added it to ensure consistent font styling across the entire page.
| <!-- This is a size option --> | ||
|
|
||
| <div> | ||
| <label class="blk" for="sz"> T-shirt Size*</label> |
There was a problem hiding this comment.
Try to avoid heavily abbreviated class names as it takes away the meaning and makes it difficult for other developers to understand. Let me know if you dont understand what I mean and I can clarify with you on slack.
There was a problem hiding this comment.
I understand it.
Thank you
|
|
||
|
|
||
| /* This is a whole form's class */ | ||
| .form{ |
There was a problem hiding this comment.
what styles here are specific to the form element?
There was a problem hiding this comment.
I just moved whole form in the middle of the page .
Sambuxc
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
I have updated all input and select options .Also, I validated all html Elements with a validator and checked accessibility with lighthouse.