mctp-estack: Don't hold a lock to send messages #51
Draft
mkj wants to merge 2 commits intoCodeConstruct:mainfrom
Draft
mctp-estack: Don't hold a lock to send messages #51mkj wants to merge 2 commits intoCodeConstruct:mainfrom
mkj wants to merge 2 commits intoCodeConstruct:mainfrom
Conversation
Helper to implement async locks Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Member
Author
|
Leaving this as Draft until I've tested on real hardware. I'm confident it's correct though. |
send_message() was holding a blocking lock across the whole send sequence (until the queue was full). This is currently a CriticalSectionMutex so would block interrupts. Instead we can poll until a sender is available. forward_packet() is now made async. Any waits will be short, until a concurrent send_message() completes or runs out of queue to copy into. Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_message() was holding a blocking lock across the whole
send sequence (until the queue was full). This is currently a
CriticalSectionMutex so would block interrupts.
Instead we can poll until a sender is available. forward_packet() is
now made async. Any waits will be short, until a concurrent
send_message() completes or runs out of queue to copy into.