Skip to content

fixed CQ for bitmessageqt.retranslateui module#1650

Draft
coolguy-cell wants to merge 1 commit intoBitmessage:v0.6from
coolguy-cell:CQfixes11
Draft

fixed CQ for bitmessageqt.retranslateui module#1650
coolguy-cell wants to merge 1 commit intoBitmessage:v0.6from
coolguy-cell:CQfixes11

Conversation

@coolguy-cell
Copy link
Copy Markdown
Contributor

flake8
pycodestyle
pylint

Comment thread src/bitmessageqt/retranslateui.py Outdated


class RetranslateMixin(object):
"""RetranslateMixin class for Qt Ui"""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you come up with a better docstring?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like something about being able to dynamically change language during runtime.

Copy link
Copy Markdown
Member

@PeterSurda PeterSurda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docstrings

@coolguy-cell coolguy-cell force-pushed the CQfixes11 branch 2 times, most recently from 527396d to 8c11b19 Compare June 18, 2020 06:10
@coolguy-cell
Copy link
Copy Markdown
Contributor Author

Done.

Comment thread src/bitmessageqt/retranslateui.py Outdated


class RetranslateMixin(object):
"""It is being able to dynamically change language during runtime."""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better wording

Comment thread src/bitmessageqt/retranslateui.py Outdated
@@ -1,9 +1,12 @@
from os import path
"""retranslateui module for Qt.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better wording

Copy link
Copy Markdown
Member

@PeterSurda PeterSurda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please improve the docstrings

@coolguy-cell coolguy-cell marked this pull request as ready for review September 9, 2020 06:53
@g1itch g1itch marked this pull request as draft August 17, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants