feat: implement external signing - phase 1#199
Merged
pranishnepal merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
pranishnepal
force-pushed
the
WCN-397/implementation
branch
from
af58283 to
7cfd5d6
Compare
This commit implements the first phase of the external signing feature, which includes the following changes: - AWM delegates the key generation and signing to Key Provider Client - Introduced new types for the APIs, Request and Response Ticket: WCN-397
pranishnepal
force-pushed
the
WCN-397/implementation
branch
from
7cfd5d6 to
dcee4fc
Compare
pranishnepal
commented
May 7, 2026
| import { DklsTypes, DklsUtils } from '@bitgo-beta/sdk-lib-mpc'; | ||
|
|
||
| describe('recoveryMpcV2', async () => { | ||
| describe('recoveryMpcV2', () => { |
Contributor
Author
There was a problem hiding this comment.
bug - describe shouldn't use async
pranishnepal
commented
May 7, 2026
| | ------------------------------ | ---------------------------------- | ------- | -------- | | ||
| | `ADVANCED_WALLET_MANAGER_PORT` | Port to listen on | `3080` | ❌ | | ||
| | `KEY_PROVIDER_URL` | URL to your key provider API implementation | - | ✅ | | ||
| | `SIGNING_MODE` | Signing mode (`local` or `external`). Use `external` to delegate key generation and signing to your key provider — the private key never leaves the HSM. | `local` | ❌ | |
Contributor
Author
There was a problem hiding this comment.
un-committing this for now while still in dev
margueriteblair
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR implements the first phase of the external signing feature, which includes the following changes:
Ticket: WCN-397
Testing
Notes
This is phase 1 - there will still be enhancements to this work - especially around UTXO signing.