Skip to content

feat(awm): backup awm client configurations#196

Merged
margueriteblair merged 1 commit intomasterfrom
margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key
May 6, 2026
Merged

feat(awm): backup awm client configurations#196
margueriteblair merged 1 commit intomasterfrom
margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key

Conversation

@margueriteblair
Copy link
Copy Markdown
Contributor

Ticket: WCN-362

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 1, 2026

@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch 2 times, most recently from f94534e to 059e29d Compare May 1, 2026 22:04
@margueriteblair margueriteblair changed the title feat(adv-wallets): backup key server configs feat(awm): backup keyserver configs May 1, 2026
@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch from e39a781 to 9e0531d Compare May 4, 2026 19:21
@margueriteblair
Copy link
Copy Markdown
Contributor Author

@claude

@margueriteblair margueriteblair changed the title feat(awm): backup keyserver configs feat(awm): backup awm client configurations May 4, 2026
@margueriteblair margueriteblair marked this pull request as ready for review May 4, 2026 19:49
@margueriteblair margueriteblair requested a review from a team as a code owner May 4, 2026 19:49
Comment thread src/masterBitgoExpress/middleware/middleware.ts
Comment thread src/initConfig.ts
Comment thread src/types/request.ts Outdated
Comment thread src/types/request.ts Outdated
@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch 3 times, most recently from c58c1a2 to 07d8951 Compare May 5, 2026 19:14
Comment thread src/initConfig.ts
Comment thread src/masterBitgoExpress/clients/advancedWalletManagerClient.ts
@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch from 07d8951 to 233fef6 Compare May 5, 2026 20:35
Copy link
Copy Markdown
Contributor

@pranavjain97 pranavjain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread src/initConfig.ts
pranavjain97
pranavjain97 previously approved these changes May 5, 2026
Comment thread src/masterBitgoExpress/middleware/middleware.ts
pranishnepal
pranishnepal previously approved these changes May 5, 2026
Copy link
Copy Markdown
Contributor

@pranishnepal pranishnepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you might need to update some tests

@margueriteblair
Copy link
Copy Markdown
Contributor Author

not impl lol. wont block on it - can do in a followup

Woops, I did make that abstraction method for the certs, but looks like it got overridden in a rebase

@margueriteblair margueriteblair dismissed stale reviews from pranishnepal and pranavjain97 via 7274989 May 6, 2026 15:43
@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch from 233fef6 to 7274989 Compare May 6, 2026 15:43
@margueriteblair margueriteblair force-pushed the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch from 7274989 to 20071b7 Compare May 6, 2026 15:46
@margueriteblair margueriteblair merged commit 020ec0d into master May 6, 2026
20 checks passed
@margueriteblair margueriteblair deleted the margieblair/wcn-362-akm-support-separate-awm-instances-for-user-and-backup-key branch May 6, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants