eth: add streaming for large data transactions and typed data#168
Merged
Conversation
Collaborator
Author
|
second commit adds actual signature verification |
benma
requested changes
Apr 20, 2026
Contributor
benma
left a comment
benma
left a comment
There was a problem hiding this comment.
Very nice! even ETHSIgnMessage got a drive-by bugfix by making it atomic ❤️
Tomasvrba
force-pushed
the
eth-stream
branch
2 times, most recently
from
c51be05 to
024bafa
Compare
benma
approved these changes
Apr 20, 2026
Contributor
benma
left a comment
benma
left a comment
There was a problem hiding this comment.
LGTM, but pls see small nit that you could fix before merging.
| require.EqualError(t, err, "string value exceeds maximum size") | ||
| } | ||
|
|
||
| func TestETHSignTypedMessageRejectsStreamingBytesOnOldFirmware(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Same, please remove. I missed this one before. The simulator test can be adjusted to do the
require.EqualError(t, err, UnsupportedError("9.26.0").Error())
check on older simulator versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.