-
Notifications
You must be signed in to change notification settings - Fork 18
Add WebP support and update dependencies #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cedric07
wants to merge
13
commits into
master
Choose a base branch
from
feat/webp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f57f759
Add WebP support and update dependencies
cedric07 db240d6
ci: use Corepack for Yarn 4.5.0 instead of latest Berry
firestar300 50732ce
ci(node.js): change order of tasks
firestar300 56120c3
fix(webpack): register WebP imagemin in plugins for dev, avoid duplic…
firestar300 d8070be
remove: delete unused background-static SCSS mixin
cedric07 803eb39
Add WebpackStaticImagesPlugin to handle static image processing
cedric07 17492e8
feat(webpack): optimize static image processing in watch mode
firestar300 8ad12c8
feat(webpack): use byte-for-byte copy for original images in static p…
firestar300 90876fc
Merge pull request #491 from BeAPI/feat/webp-plugin
cedric07 0a61e3b
refactor: remove JPEG images and update to WebP format
cedric07 fc805ae
refactor: remove WebpackStaticImagesPlugin and its configuration
cedric07 c5fb607
refactor: update SVGO configuration for compatibility with SVGO 3
cedric07 eb5e0fa
fix svgo config comment
cedric07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,16 @@ | ||
| module.exports = { | ||
| plugins: [ | ||
| { cleanupAttrs: true }, | ||
| { removeDoctype: true }, | ||
| { removeXMLProcInst: true }, | ||
| { removeComments: true }, | ||
| { removeMetadata: true }, | ||
| { removeTitle: true }, | ||
| { removeDesc: true }, | ||
| { removeUselessDefs: true }, | ||
| { removeEditorsNSData: true }, | ||
| { removeEmptyAttrs: true }, | ||
| { removeHiddenElems: true }, | ||
| { removeEmptyText: true }, | ||
| { removeEmptyContainers: true }, | ||
| { cleanupEnableBackground: true }, | ||
| { convertStyleToAttrs: true }, | ||
| { convertColors: true }, | ||
| { convertPathData: true }, | ||
| { convertTransform: true }, | ||
| { removeUnknownsAndDefaults: true }, | ||
| { removeNonInheritableGroupAttrs: true }, | ||
| { removeUselessStrokeAndFill: true }, | ||
| { removeUnusedNS: true }, | ||
| { cleanupIDs: true }, | ||
| { cleanupNumericValues: true }, | ||
| { moveElemsAttrsToGroup: true }, | ||
| { moveGroupAttrsToElems: true }, | ||
| { collapseGroups: true }, | ||
| { removeRasterImages: false }, | ||
| { mergePaths: true }, | ||
| { convertShapeToPath: true }, | ||
| { sortAttrs: true }, | ||
| { removeDimensions: false }, | ||
| { prefixIds: true }, | ||
| { removeViewBox: false }, | ||
| { | ||
| name: 'preset-default', | ||
| params: { | ||
| overrides: { | ||
| // Disable a plugin included by default that you don't want (false) | ||
| removeViewBox: false, | ||
| }, | ||
| }, | ||
| }, | ||
| // Plugins that are not in the "preset-default" and that you want to activate | ||
| 'convertStyleToAttrs', | ||
| 'prefixIds', | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ImageMinimizerPlugin moved from optimization.minimizer to plugins array
Medium Severity
ImageMinimizerPluginwith itsminimizerconfig was moved fromoptimization.minimizer(inwebpack.common.js) to thepluginsarray (inplugins.js). The PR description itself shows the correct pattern: the minimizer belongs inoptimization.minimizerand only the generator belongs inplugins. Placing it in thepluginsarray bypasses webpack's optimization pipeline, losing caching and deduplication benefits. Community reports indicate this can cause significantly slower builds and high CPU usage with larger image sets. The plugin needs to be inoptimization.minimizer— either back inwebpack.common.jsor inwebpack.prod.js.Additional Locations (1)
config/webpack.common.js#L12-L14Reviewed by Cursor Bugbot for commit eb5e0fa. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firestar300 Le fait que t'as déplacé ça, le bugbot remonte ce soucis ? logique pour toi ?