BHoM Tkinter bug fixes and improvements

Python_Engine/Python/src/python_toolkit/bhom_tkinter/bhom_base_window.py

@@ -51,7 +51,7 @@ def __init__(
         on_close_window: Optional[Callable] = None,
         theme_mode:str = "auto",
         widgets: Optional[List[BHoMBaseWidget]] = None,
-        top_most: bool = True,
+        top_most: bool = False,
         fullscreen: bool = False,
         buttons_side: Literal["left", "right"] = "right",
         grid_dimensions: Optional[tuple[int, int]] = None,
@@ -91,8 +91,9 @@ def __init__(
         self.resizable(resizable, resizable)
 
         self.top_most = top_most
-        if self.top_most:
-            self.attributes("-topmost", True)
+        self.attributes("-topmost", True)
+        if not self.top_most:
+            self.after(0, lambda: self.attributes("-topmost", False))
 
         self.fullscreen = fullscreen
 
@@ -555,6 +556,10 @@ def refresh_sizing(self) -> None:
         """Recalculate and apply window sizing (useful after adding widgets)."""
         self._apply_sizing()
 
+    def close(self) -> None:
+        """Close and destroy the window. Override in subclasses for custom close behaviour."""
+        self.destroy_root()
+
     def destroy_root(self) -> None:
         """Safely terminate and destroy the Tk root window."""
 

Python_Engine/Python/src/python_toolkit/bhom_tkinter/widgets/_widgets_base.py

@@ -30,6 +30,7 @@ def __init__(
             custom_validation: Optional[Callable[[object], Tuple[bool, Optional[str], Optional[Literal['info', 'warning', 'error']]]]] = None,
             disable_validation: bool = False,
             build_options: BuildOptions = PackingOptions(),
+            on_change: Optional[Callable] = None,
             **kwargs):
         """
         Initialize the widget base.
@@ -46,6 +47,10 @@ def __init__(
                 Receives the current widget value and must return
                 `(is_valid, message, severity)`.
             disable_validation: When `True`, all validation returns valid.
+            on_change: Optional callback invoked whenever the widget value
+                changes.  The current value is passed as the single argument.
+                Supported by all widgets; supplements widget-specific `command`
+                parameters where those exist.
             **kwargs: Additional Frame options
         """
         super().__init__(parent, **kwargs)
@@ -57,6 +62,7 @@ def __init__(
         self.fill_extents = self._normalise_bool(fill_extents)
         self.custom_validation = custom_validation
         self.disable_validation = bool(disable_validation)
+        self.on_change: Optional[Callable] = on_change
 
         if id is None:
             self.id = str(uuid4())
@@ -213,7 +219,7 @@ def align_child_text(self, widget: tk.Widget, alignment: Optional[Literal['left'
             self.alignment = self._normalise_alignment(alignment)
 
         self._apply_text_alignment(widget)
-
+        
         if alignment is not None:
             self.alignment = previous_alignment
 
@@ -247,6 +253,22 @@ def set_fill_extents(self, fill_extents: bool) -> None:
             label.pack_configure(anchor=self._pack_anchor)
             self._apply_text_alignment(label)
 
+    def _fire_on_change(self, value: object) -> None:
+        """Invoke the `on_change` callback with the current widget value.
+
+        This is called internally by each widget subclass whenever its value
+        changes.  It is safe to call even when `on_change` is `None`.
+
+        Args:
+            value: The current widget value to pass to the callback.
+        """
+        if self.on_change is not None:
+            try:
+                self.on_change(value)
+            except Exception:
+                CONSOLE_LOGGER.error("An error occurred when handling an `on_change` event.", exc_info=1)
+                pass
+
     @abstractmethod
     def get(self):
         """Get the current value of the widget."""

Python_Engine/Python/src/python_toolkit/bhom_tkinter/widgets/button.py

@@ -28,6 +28,7 @@ def __init__(
 		super().__init__(parent, **kwargs)
 
 		self._user_command = command
+		self._click_count = 0
 		self.button = ttk.Button(
 			self.content_frame,
 			text=text,
@@ -40,20 +41,21 @@ def __init__(
 
 	def _on_click(self):
 		"""Internal click handler increments counter and calls user callback."""
+		self._click_count += 1
 		if self._user_command:
 			try:
 				self._user_command()
 			except Exception as e:
 				CONSOLE_LOGGER.error(f"Unhandled exception when trying to perform custom command: {e}", exc_info=True)
-
 
 	def get(self):
-		"""Return None as nothing to get."""
-		return None
+		"""Return the number of times the button has been clicked."""
+		return self._click_count
 
 	def set(self, value):
-		"""No set method."""
-		pass
+		"""Update the button label text when passed a string."""
+		if isinstance(value, str):
+			self.button.configure(text=value)
 
 	def validate(self) -> tuple[bool, Optional[str], Optional[Literal['info', 'warning', 'error']]]:
 		"""Button has no user-editable state, so validation is always valid unless overridden."""

Python_Engine/Python/src/python_toolkit/bhom_tkinter/widgets/check_box_selection.py

@@ -5,7 +5,6 @@
 from typing import Optional, List, Callable, Tuple, Literal
 
 from python_toolkit.bhom_tkinter.widgets._widgets_base import BHoMBaseWidget
-from python_toolkit.bhom_tkinter.widgets.button import Button
 
 class CheckboxSelection(BHoMBaseWidget):
 	"""A reusable checkbox selection widget built from a list of fields, allowing multiple selections."""
@@ -51,7 +50,7 @@ def __init__(
 
 		# Sub-frame for checkbox controls
 		self.buttons_frame = ttk.Frame(self.content_frame)
-		self.buttons_frame.pack(side="top", fill="x", expand=True)
+		self.buttons_frame.pack(side="top", anchor=self._pack_anchor)
 
 		self._build_buttons()
 
@@ -98,6 +97,7 @@ def _on_select_field(self, field):
 		"""Handle checkbox selection change."""
 		if self.command:
 			self.command(self.get())
+		self._fire_on_change(self.get())
 
 	def get(self) -> List[str]:
 		"""Return a list of currently selected values.
@@ -123,20 +123,23 @@ def select_all(self):
 			var.set(True)
 		if self.command:
 			self.command(self.get())
+		self._fire_on_change(self.get())
 
 	def deselect_all(self):
 		"""Deselect all checkboxes."""
 		for var in self.value_vars.values():
 			var.set(False)
 		if self.command:
 			self.command(self.get())
+		self._fire_on_change(self.get())
 
 	def toggle_all(self):
 		"""Toggle all checkbox states."""
 		for var in self.value_vars.values():
 			var.set(not var.get())
 		if self.command:
 			self.command(self.get())
+		self._fire_on_change(self.get())
 
 	def set_fields(self, fields: List[str], defaults: Optional[List[str]] = None):
 		"""Replace the available fields and rebuild the widget.
@@ -151,14 +154,6 @@ def set_fields(self, fields: List[str], defaults: Optional[List[str]] = None):
 		if defaults:
 			self.set(defaults)
 
-	def pack(self, **kwargs):
-		"""Pack the widget with the given options.
-
-		Args:
-			**kwargs: Pack geometry manager options.
-		"""
-		super().pack(**kwargs)
-
 	def validate(self) -> tuple[bool, Optional[str], Optional[Literal['info', 'warning', 'error']]]:
 		"""Validate the current selection against min/max constraints.