Skip to content

Remove Cargo.toml when being installed via vcpkg#7112

Merged
RickWinter merged 1 commit into
Azure:mainfrom
antkmsft:remove-cargotoml-in-vcpkg
May 12, 2026
Merged

Remove Cargo.toml when being installed via vcpkg#7112
RickWinter merged 1 commit into
Azure:mainfrom
antkmsft:remove-cargotoml-in-vcpkg

Conversation

@antkmsft
Copy link
Copy Markdown
Member

Remove Cargo.toml files from the source tree when being installed via vcpkg.
This will remove false component governance alerts for our clients, so they won't scan for outdated dependencies in Rust code.
We never build Rust when being installed via vcpkg - azure-core-amqp-cpp ships with -DDISABLE_RUST_IN_BUILD=ON.

Copilot AI review requested due to automatic review settings May 11, 2026 23:41
@github-actions github-actions Bot added App Configuration Azure.ApplicationModel.Configuration Attestation Azure.Core Azure.Identity EngSys This issue is impacting the engineering system. Event Hubs labels May 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates multiple vcpkg portfile.cmake scripts to remove Rust Cargo.toml manifests from the extracted Azure SDK for C++ source tree during vcpkg builds, aiming to prevent downstream component governance scanners from flagging Rust dependencies that aren’t built/used in these vcpkg scenarios.

Changes:

  • Add file(GLOB_RECURSE ...) + file(REMOVE_RECURSE ...) steps intended to delete Cargo.toml during vcpkg packaging for several ports.
  • Apply the same removal pattern broadly across core, identity, keyvault, storage, tables, eventhubs, attestation, appconfiguration, and template ports.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 19 comments.

Show a summary per file
File Description
sdk/template/azure-template/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/tables/azure-data-tables/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/storage/azure-storage-queues/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/storage/azure-storage-files-shares/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/storage/azure-storage-files-datalake/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/storage/azure-storage-common/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/storage/azure-storage-blobs/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/keyvault/azure-security-keyvault-secrets/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/keyvault/azure-security-keyvault-keys/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/keyvault/azure-security-keyvault-certificates/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/keyvault/azure-security-keyvault-administration/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/identity/azure-identity/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/eventhubs/azure-messaging-eventhubs/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-blob/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/core/azure-core/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/core/azure-core-tracing-opentelemetry/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/core/azure-core-amqp/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build (notably relevant due to embedded Rust).
sdk/attestation/azure-security-attestation/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.
sdk/appconfiguration/azure-data-appconfiguration/vcpkg/portfile.cmake Attempts to remove Cargo.toml from extracted sources before configuring the build.

Comment thread sdk/template/azure-template/vcpkg/portfile.cmake
Comment thread sdk/tables/azure-data-tables/vcpkg/portfile.cmake
Comment thread sdk/storage/azure-storage-queues/vcpkg/portfile.cmake
Comment thread sdk/storage/azure-storage-files-shares/vcpkg/portfile.cmake
Comment thread sdk/storage/azure-storage-files-datalake/vcpkg/portfile.cmake
Comment thread sdk/core/azure-core/vcpkg/portfile.cmake
Comment thread sdk/core/azure-core-tracing-opentelemetry/vcpkg/portfile.cmake
Comment thread sdk/core/azure-core-amqp/vcpkg/portfile.cmake
Comment thread sdk/attestation/azure-security-attestation/vcpkg/portfile.cmake
@RickWinter RickWinter merged commit f1039fe into Azure:main May 12, 2026
398 checks passed
@github-project-automation github-project-automation Bot moved this from Untriaged to Done in Azure SDK for Key Vault May 12, 2026
@antkmsft antkmsft deleted the remove-cargotoml-in-vcpkg branch May 12, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Configuration Azure.ApplicationModel.Configuration Attestation Azure.Core Azure.Identity EngSys This issue is impacting the engineering system. Event Hubs KeyVault Storage Storage Service (Queues, Blobs, Files) Tables

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants