fix(designer): Remove max token limit for agents#9268
Open
Eric-B-Wu wants to merge 14 commits into
Open
Conversation
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | None |
| Commit Type | ✅ | None |
| Risk Level | ✅ | None |
| What & Why | ✅ | Optional: mention the removed 8192 cap explicitly |
| Impact of Change | ✅ | Optional: add more detail on affected scenarios |
| Test Plan | ✅ | Add the tested environment/scenario if available |
| Contributors | ✅ | None |
| Screenshots/Videos | ✅ | Optional only if visually relevant |
Overall: this PR passes review for title/body quality. The advised risk level matches the submitted risk level (Medium).
Last updated: Wed, 10 Jun 2026 00:37:59 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates agent manifests to remove the previously enforced 8192 maximum token limit, and adjusts Designer v2 canvas selection handling to prevent the details panel from closing immediately due to React Flow selection churn (notably affecting scope node clickability).
Changes:
- Removed the
maximum: 8192constraint (and updated descriptions) for themaxTokensparameter in both Standard and Consumption agent loop manifests. - Updated Designer v2 React Flow selection commit logic to ignore empty selection updates outside of marquee selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/agentloop.ts | Removes the max token upper bound from the Standard agent loop manifest schema. |
| libs/logic-apps-shared/src/designer-client-services/lib/consumption/manifests/agentloop.ts | Removes the max token upper bound from the Consumption agent loop manifest schema. |
| libs/designer-v2/src/lib/ui/DesignerReactFlow.tsx | Changes selection commit behavior to avoid clearing the panel on certain empty selection events (aimed at fixing non-clickable scope nodes). |
Comment on lines
+473
to
+477
| // immediately after a single-click open. Real "clear" paths (pane click, Escape) go | ||
| // through their own handlers. | ||
| if (ids.length === 0) { | ||
| return; | ||
| } |
Comment on lines
+472
to
+474
| // the un-tagged id in the redux selection). Tearing down the panel here would close it | ||
| // immediately after a single-click open. Real "clear" paths (pane click, Escape) go | ||
| // through their own handlers. |
Contributor
📊 Coverage CheckThe following changed files need attention: ❌ Please add tests for the uncovered files before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Removing max token limit for agents now that models are more advanced and need higher token limits
Also fixing an issue where scope nodes were not clickable
Impact of Change
Test Plan
Contributors
@Eric-B-Wu
Screenshots/Videos