Skip to content

fix(designer): Remove max token limit for agents#9268

Open
Eric-B-Wu wants to merge 14 commits into
mainfrom
eric/tokenLimit
Open

fix(designer): Remove max token limit for agents#9268
Eric-B-Wu wants to merge 14 commits into
mainfrom
eric/tokenLimit

Conversation

@Eric-B-Wu

@Eric-B-Wu Eric-B-Wu commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Removing max token limit for agents now that models are more advanced and need higher token limits

Also fixing an issue where scope nodes were not clickable

Impact of Change

  • Users: Agent workflows can now be configured with higher max token limits, rather than being capped at 8192.
  • Developers: small fix to making sure scope nodes are clickable
  • System: no system changes

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@Eric-B-Wu

Screenshots/Videos

Copilot AI review requested due to automatic review settings June 10, 2026 00:34
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(designer): Remove max token limit for agents
  • Issue: No issue — this is a clear, specific title that describes the user-facing change.
  • Recommendation: None.

Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

⚠️ Risk Level

  • The selected risk level is Medium, which is reasonable for a UI/manifest change affecting agent configuration.
  • Advised risk level from diff: Medium.

What & Why

  • Current: `Removing max token limit for agents now that models are more advanced and need higher token limits

Also fixing an issue where scope nodes were not clickable`

  • Issue: No blocking issue — the change is described clearly and concisely.
  • Recommendation: If you want to make this even stronger, mention the 8192 cap explicitly and note that the scope-node clickability fix is part of the same PR.

Impact of Change

  • The impact section is present and gives a reasonable summary of user, developer, and system impact.
  • Recommendation:
    • Users: Good as written; optionally mention the previous 8192 ceiling was removed.
    • Developers: Good as written.
    • System: Good as written.

Test Plan

  • Manual testing is checked, and the diff is backed by code changes rather than docs-only changes.
  • Automated tests are not required to pass here because the PR includes a clear manual testing declaration, and the change is small/scope-limited.
  • Recommendation: Consider adding the specific test environment or scenario under Tested in: so reviewers can reproduce validation more easily.

Contributors

  • Contributors are listed (@eric-b-wu).
  • Recommendation: No change needed unless there were additional PM/design contributors to credit.

Screenshots/Videos

  • No screenshots/videos are provided.
  • Assessment: This is acceptable if the UI change is not visually meaningful or if the manual validation covered the behavior sufficiently.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why Optional: mention the removed 8192 cap explicitly
Impact of Change Optional: add more detail on affected scenarios
Test Plan Add the tested environment/scenario if available
Contributors None
Screenshots/Videos Optional only if visually relevant

Overall: this PR passes review for title/body quality. The advised risk level matches the submitted risk level (Medium).


Last updated: Wed, 10 Jun 2026 00:37:59 GMT

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates agent manifests to remove the previously enforced 8192 maximum token limit, and adjusts Designer v2 canvas selection handling to prevent the details panel from closing immediately due to React Flow selection churn (notably affecting scope node clickability).

Changes:

  • Removed the maximum: 8192 constraint (and updated descriptions) for the maxTokens parameter in both Standard and Consumption agent loop manifests.
  • Updated Designer v2 React Flow selection commit logic to ignore empty selection updates outside of marquee selection.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/agentloop.ts Removes the max token upper bound from the Standard agent loop manifest schema.
libs/logic-apps-shared/src/designer-client-services/lib/consumption/manifests/agentloop.ts Removes the max token upper bound from the Consumption agent loop manifest schema.
libs/designer-v2/src/lib/ui/DesignerReactFlow.tsx Changes selection commit behavior to avoid clearing the panel on certain empty selection events (aimed at fixing non-clickable scope nodes).

Comment on lines +473 to +477
// immediately after a single-click open. Real "clear" paths (pane click, Escape) go
// through their own handlers.
if (ids.length === 0) {
return;
}
Comment on lines +472 to +474
// the un-tagged id in the redux selection). Tearing down the panel here would close it
// immediately after a single-click open. Real "clear" paths (pane click, Escape) go
// through their own handlers.
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

libs/designer-v2/src/lib/ui/DesignerReactFlow.tsx - 0% covered

Please add tests for the uncovered files before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants