fix: wrong order of resolving function expression and operands expression for call_indirect#2994
Open
Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Open
fix: wrong order of resolving function expression and operands expression for call_indirect#2994Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Conversation
Changqing-JING
changed the title
Changqing-JING
added a commit
to wasm-ecosystem/warpo
that referenced
this pull request
Mar 23, 2026
…pression for call_indirect (#429) carry over from AssemblyScript/assemblyscript#2994
Contributor
Author
|
Can some maintainer help to review this PR? |
MaxGraey
requested review from
CountBleck and
HerrCai0907
and removed request for
HerrCai0907
Member
|
It makes the semantics of as and ts more consistent, with a slight performance loss, yet I believe this trade-off is worthwhile. @MaxGraey WDYT? |
Member
|
I'm not sure. I think AssemblyScript provides much more obvious and logical approach. JavaScript has historically had a lot of quirks, and I think this is one of them. Also, it's breaking change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989
Changes proposed in this pull request:
Fix wrong order of resolving function expression and operands expression for call_indirect