[PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo calculations.#16002
[PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo calculations.#16002Lolle2001 wants to merge 6 commits intoAliceO2Group:masterfrom
jetD0AngSubstructure.cxx to include Monte Carlo calculations.#16002Conversation
|
O2 linter results: ❌ 0 errors, |
|
@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914 |
Hi @vkucera, could you reopen this PR please? |
Hi @Lolle2001 , sure, but I think you should see that option too below. |
Hi @vkucera, I am afraid I do not see such an option. Only the buttons |
Please send me a screenshot of the bottom of your PR on GitHub in a private message. |
|
Don't mark other people's suggestions as resolved, especially if you have not resolved them yet. It is explicitly written in the guidelines. |
|
Hi @vkucera, I have pushed new commits. Can you review them? |
| /* | ||
| // Experimental Data (analyseDataChargedSubstructure) | ||
| */ | ||
| constexpr const char* ex_col = "ex_col"; // Collision Counter |
There was a problem hiding this comment.
constexpr const does not make sense. Remove const and fix the names.
- Updated the includes according to the O2 guidelines. - Removed registry as an argument in the `analyse` methods.
Co-authored-by: Copilot <copilot@github.com>
|
You just overwrote the entire PR. You are not supposed to do that. It is explicitly written in the contribution guidelines. |
|
Also please change the PR title to something meaningful that summarises the scope and content of the changes. |
I intended to sync my fork with my local branch, but did not know this would happen. |
jetD0AngSubstructure.cxx to include Monte Carlo calculations.
Uh oh!
There was an error while loading. Please reload this page.