Skip to content

[PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo calculations.#16002

Open
Lolle2001 wants to merge 6 commits intoAliceO2Group:masterfrom
Lolle2001:dev
Open

[PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo calculations.#16002
Lolle2001 wants to merge 6 commits intoAliceO2Group:masterfrom
Lolle2001:dev

Conversation

@Lolle2001
Copy link
Copy Markdown

@Lolle2001 Lolle2001 commented Apr 28, 2026

  • Added task to match detector level and particle level Monte Carlo particles.
  • Added an additional task to calculate the Monte Carlo efficiency.
  • Using templated analyse functions to easily define process functions for other particles than D0 if desired.
  • Updated the includes according to the O2 guidelines.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

O2 linter results: ❌ 0 errors, ⚠️ 80 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Implemented suggestions from comments on previous pull request. [PWGJE] Implemented suggestions from comments on previous pull request. Apr 28, 2026
@Lolle2001 Lolle2001 closed this Apr 29, 2026
@Lolle2001 Lolle2001 reopened this Apr 29, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 29, 2026

@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914

@vkucera vkucera closed this Apr 29, 2026
@Lolle2001
Copy link
Copy Markdown
Author

Lolle2001 commented Apr 29, 2026

Hi @vkucera, @pdhankhe will close the one from before.

EDIT: @pdhankhe has closed it, could you please open this one, since I will be the main contributor to this code.

@Lolle2001
Copy link
Copy Markdown
Author

@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914

Hi @vkucera, could you reopen this PR please?

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 30, 2026

@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914

Hi @vkucera, could you reopen this PR please?

Hi @Lolle2001 , sure, but I think you should see that option too below.

@Lolle2001
Copy link
Copy Markdown
Author

@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914

Hi @vkucera, could you reopen this PR please?

Hi @Lolle2001 , sure, but I think you should see that option too below.

Hi @vkucera, I am afraid I do not see such an option. Only the buttons delete branch and comment.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 30, 2026

@Lolle2001 Please avoid fragmenting PRs. Update the existing one instead. #15914

Hi @vkucera, could you reopen this PR please?

Hi @Lolle2001 , sure, but I think you should see that option too below.

Hi @vkucera, I am afraid I do not see such an option. Only the buttons delete branch and comment.

Please send me a screenshot of the bottom of your PR on GitHub in a private message.

@vkucera vkucera reopened this Apr 30, 2026
Comment thread PWGJE/Tasks/jetD0AngSubstructure.cxx Outdated
Comment thread PWGJE/Tasks/jetD0AngSubstructure.cxx Outdated
Comment thread PWGJE/Tasks/jetD0AngSubstructure.cxx Outdated
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 30, 2026

Don't mark other people's suggestions as resolved, especially if you have not resolved them yet. It is explicitly written in the guidelines.

@Lolle2001
Copy link
Copy Markdown
Author

Hi @vkucera, I have pushed new commits. Can you review them?

/*
// Experimental Data (analyseDataChargedSubstructure)
*/
constexpr const char* ex_col = "ex_col"; // Collision Counter
Copy link
Copy Markdown
Collaborator

@vkucera vkucera May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr const does not make sense. Remove const and fix the names.

Lolle2001 added 3 commits May 4, 2026 16:09
- Updated the includes according to the O2 guidelines.
- Removed registry as an argument in the `analyse` methods.
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

You just overwrote the entire PR. You are not supposed to do that. It is explicitly written in the contribution guidelines.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

Also please change the PR title to something meaningful that summarises the scope and content of the changes.

@Lolle2001
Copy link
Copy Markdown
Author

You just overwrote the entire PR. You are not supposed to do that. It is explicitly written in the contribution guidelines.

I intended to sync my fork with my local branch, but did not know this would happen.

@Lolle2001 Lolle2001 changed the title [PWGJE] Implemented suggestions from comments on previous pull request. [PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo calculations. May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants