Skip to content

[PWGJE] Added functionality to calculate efficiency for non-hooked MC#15991

Merged
smaff92 merged 4 commits intoAliceO2Group:masterfrom
smaff92:master
Apr 28, 2026
Merged

[PWGJE] Added functionality to calculate efficiency for non-hooked MC#15991
smaff92 merged 4 commits intoAliceO2Group:masterfrom
smaff92:master

Conversation

@smaff92
Copy link
Copy Markdown
Collaborator

@smaff92 smaff92 commented Apr 28, 2026

No description provided.

@github-actions github-actions Bot added the pwgje label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026 •
edited
Loading

O2 linter results: ❌ 178 errors, ⚠️ 229 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Added functionality to calculate efficiency for non-hooked MC [PWGJE] Added functionality to calculate efficiency for non-hooked MC Apr 28, 2026
@alibuild alibuild mentioned this pull request Apr 28, 2026
Merged
smaff92 added a commit to smaff92/O2Physics that referenced this pull request Apr 28, 2026
@smaff92
Merge pull request #44 from alibuild/alibot-cleanup-15991
7c2ad48 
[PWGJE] Please consider the following formatting changes to AliceO2Group#15991
@smaff92 smaff92 enabled auto-merge (squash) April 28, 2026 09:36
nzardosh
nzardosh reviewed Apr 28, 2026
View reviewed changes
Comment thread PWGJE/Tasks/statPromptPhoton.cxx Outdated
if (std::fabs(mcParticle.eta()) > 0.62)
continue;
bool insideCalPhi = false;
if ((mcParticle.phi() > 1.42 && mcParticle.phi() < 3.26) || (mcParticle.phi() > 4.56 && mcParticle.phi() < 5.70))
Copy link
Copy Markdown
Collaborator

@nzardosh nzardosh Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if you could make these hard coded values configurable

Copy link
Copy Markdown
Collaborator Author

@smaff92 smaff92 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nima,

Done! I also changed the previous cfg to int, so the build should clear now.

Cheers!

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 28, 2026

Error while checking build/O2Physics/o2 for 7c2ad48 at 2026-04-28 11:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/statPromptPhoton.cxx:109:75: error: narrowing conversion of '((statPromptPhoton*)this)->statPromptPhoton::cfgMCptNbins.o2::framework::Configurable<double>::o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>.o2::framework::ConfigurablePolicyConst<double, o2::framework::kGeneric>::operator double()' from 'double' to 'int' [-Werror=narrowing]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Apr 28, 2026
Merged
@smaff92
Merge pull request #45 from alibuild/alibot-cleanup-15991
b6604fc 
[PWGJE] Please consider the following formatting changes to AliceO2Group#15991
@nzardosh nzardosh self-requested a review April 28, 2026 14:25
@smaff92 smaff92 merged commit fa25ba0 into AliceO2Group:master Apr 28, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@raymondEhlers raymondEhlers Awaiting requested review from raymondEhlers raymondEhlers is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smaff92 @alibuild @nzardosh