Skip to content

Render Nova connector setup cards#1071

Open
ishaanxgupta wants to merge 6 commits into
mainfrom
codex/nova-chat-plugin-mcp-setup
Open

Render Nova connector setup cards#1071
ishaanxgupta wants to merge 6 commits into
mainfrom
codex/nova-chat-plugin-mcp-setup

Conversation

@ishaanxgupta

@ishaanxgupta ishaanxgupta commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add custom assistant-message rendering for Nova connector tool results
  • Show integration-style setup/status cards with icon, status pill, setup steps, docs links, copy buttons, and key reveal/generate action
  • Keep plugin API keys client-side only by calling the existing /v3/auth/key?client=... endpoint from the UI
  • Add Nova empty-state suggestions for Cursor setup and active plugins

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp fd98c5e Jun 09 2026, 01:48 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app fd98c5e Commit Preview URL

Branch Preview URL
Jun 09 2026, 01:50 PM

@ishaanxgupta ishaanxgupta changed the title [codex] Render Nova connector setup cards Render Nova connector setup cards Jun 9, 2026
@ishaanxgupta ishaanxgupta marked this pull request as ready for review June 9, 2026 13:53
@graphite-app graphite-app Bot requested a review from Dhravya June 9, 2026 13:53
@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown

Claude finished @ishaanxgupta's task in 1m 51s —— View job


Review Complete

  • Get PR diff and analyze changes
  • Read changed files for full context
  • Check for existing review comments
  • Perform code review for bugs, security issues, and logic errors
  • Submit review

Summary: This PR adds custom UI rendering for Nova connector setup cards in chat messages. The code is well-structured, follows established patterns for API key fetching, and handles edge cases properly (error states, image fallbacks, deduplication of connector cards). No bugs, security issues, or logic errors found.

Score: 10/10 — Ready to ship.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds custom UI rendering for Nova connector tool results, displaying integration setup cards with status indicators, install steps, and API key generation.

Issues found: None — this looks good to ship.

The implementation is clean and follows established patterns:

  • API key fetching (/v3/auth/key?client=...) matches the existing pattern used in select-spaces-modal.tsx, integrations-view.tsx, and plugins-detail.tsx
  • Proper error handling throughout with loading/error states
  • The shouldSkipNovaConnectorPart deduplication logic correctly prioritizes prepareNovaPluginSetup over getNovaConnectorSetup to avoid duplicate cards
  • Image fallback handling uses data-fallbackApplied flag to prevent infinite error loops
  • Accessibility is handled with type="button", aria-expanded, and proper focus states
  • CSS changes improve code block contrast without breaking existing styles

Score: 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant