fix(openai-sdk): use AsyncSupermemory and correct client API calls#1063
Open
icyzh wants to merge 1 commit into
Open
fix(openai-sdk): use AsyncSupermemory and correct client API calls#1063icyzh wants to merge 1 commit into
icyzh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openai-sdk
SupermemoryToolsclass initializes a syncSupermemory()client but all its methods areasyncandawaititTypeErrorat runtime. On top of that, every.add()call targets the top-level client, butAsyncSupermemoryexposesadd()on the.memoriessub-resource (client.memories.add(...)). Confirmed locally with the installed SDK:That missing method means every memory-add call silently hits the
except Exceptionhandler and returns{"success": false, "error": "..."}. Even if it did reach the API, the raw Pydantic response gets fed tojson.dumps()without.model_dump()anotherTypeError.This rewrites the client init to use
AsyncSupermemory, changes all.add()calls to.memories.add(), and calls.model_dump()on Pydantic responses before serialization. Test imports are also fixed ,the first fallback referenced a non-existent package name (supermemory_openai_sdk) and the second used a wrong module path.