Skip to content

fix(modal): preserve spacing in workspace delete confirmation label#4929

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/modal
Jun 9, 2026
Merged

fix(modal): preserve spacing in workspace delete confirmation label#4929
waleedlatif1 merged 1 commit into
stagingfrom
fix/modal

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Fixed the workspace delete confirmation label rendering as Type<workspace name>to confirm with no spaces
  • The label renders inside ChipModalField's inline-flex <Label>, which drops whitespace-only text nodes between flex items; wrapping the title in a single <span> keeps the spaces as normal inline content
  • Matches the existing pattern at version-description-modal.tsx

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jun 9, 2026 7:24pm

Request Review

@cursor

cursor Bot commented Jun 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single UI copy rendering fix in the delete modal with no auth, data, or API impact.

Overview
Fixes the workspace delete confirmation field label so it reads Type {workspace} to confirm with proper spaces instead of collapsing to Type{workspace}to confirm.

The ChipModalField title is changed from a React fragment to a single wrapping <span>, so whitespace is preserved inside the parent inline-flex label (same approach as version-description-modal.tsx).

Reviewed by Cursor Bugbot for commit a4a810b. Configure here.

@waleedlatif1 waleedlatif1 merged commit 1e35656 into staging Jun 9, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/modal branch June 9, 2026 19:26
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a display bug where the workspace delete confirmation label rendered as Type<workspace name>to confirm with no spaces, because the Radix Label component uses inline-flex and whitespace-only text nodes between flex items are collapsed. Wrapping the label content in a <span> instead of a React fragment restores normal inline layout and preserves spaces.

  • The single-line change in delete-modal.tsx replaces <>…</> with <span>…</span> so the title renders as one contiguous inline node rather than bare text nodes in a flex container.
  • The fix mirrors the existing pattern used in version-description-modal.tsx.

Confidence Score: 5/5

A minimal, focused one-line change that corrects a visual spacing defect in the workspace delete confirmation label with no logic or state implications.

The change swaps a React fragment for a <span> wrapper in a purely presentational label — no logic, data, or state is touched. The approach matches the established pattern already used elsewhere in the codebase.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/delete-modal/delete-modal.tsx Replaces React fragment with a wrapper for the workspace delete confirmation label, fixing whitespace collapse inside the inline-flex Label element.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ChipConfirmModal] --> B[ChipModalField type=input]
    B --> C[Label inline-flex]
    C --> D_old["Before: React Fragment <>\nText nodes as direct flex children\n→ whitespace collapsed"]
    C --> D_new["After: <span> wrapper\nSingle flex child with inline layout\n→ spaces preserved"]
    style D_old fill:#ffcccc,stroke:#cc0000
    style D_new fill:#ccffcc,stroke:#009900
Loading

Reviews (1): Last reviewed commit: "fix(modal): preserve spacing in workspac..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant