From 8f74c21d72db32d0ce4c44dfc4b1136fe46d6216 Mon Sep 17 00:00:00 2001 From: Matheus Cruz Date: Fri, 24 Apr 2026 11:01:30 -0300 Subject: [PATCH 1/3] Add convenience no-arg instance() method for WorkflowDefinition Signed-off-by: Matheus Cruz --- .../java/io/serverlessworkflow/impl/WorkflowDefinition.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java index 770f41367..201398eaf 100644 --- a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java +++ b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java @@ -129,6 +129,10 @@ public WorkflowInstance instance(Object input) { return new WorkflowMutableInstance(this, application().idFactory().get(), inputModel); } + public WorkflowInstance instance() { + return instance(Map.of()); + } + Optional inputSchemaValidator() { return inputSchemaValidator; } From 447721a2f5ea6644accaeb95dbc6baf5c096d66f Mon Sep 17 00:00:00 2001 From: Matheus Cruz Date: Fri, 24 Apr 2026 12:30:08 -0300 Subject: [PATCH 2/3] Change Map.of to null Signed-off-by: Matheus Cruz --- .../io/serverlessworkflow/impl/WorkflowDefinition.java | 2 +- .../java/io/serverlessworkflow/impl/test/OpenAPITest.java | 8 ++++---- .../io/serverlessworkflow/impl/test/SubWorkflowTest.java | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java index 201398eaf..a4065024d 100644 --- a/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java +++ b/impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowDefinition.java @@ -130,7 +130,7 @@ public WorkflowInstance instance(Object input) { } public WorkflowInstance instance() { - return instance(Map.of()); + return instance(null); } Optional inputSchemaValidator() { diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java index b62d2e471..267117232 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java @@ -149,7 +149,7 @@ public void testOpenAPIBearerQueryInlinedBodyWithPositiveResponse() throws Excep .setResponseCode(201)); Map result = - app.workflowDefinition(workflow).instance(Map.of()).start().get().asMap().orElseThrow(); + app.workflowDefinition(workflow).instance().start().get().asMap().orElseThrow(); RecordedRequest restRequest = restServer.takeRequest(); assertEquals("POST", restRequest.getMethod()); @@ -196,7 +196,7 @@ public void testOpenAPIBearerQueryInlinedBodyWithNegativeResponse() throws Excep Exception.class, () -> app.workflowDefinition(workflow) - .instance(Map.of()) + .instance() .start() .get() .asMap() @@ -244,11 +244,11 @@ public void testOpenAPIGetWithPositiveResponse() throws Exception { .setResponseCode(200)); WorkflowDefinition definition = app.workflowDefinition(workflow); - assertData(definition.instance(Map.of()).start().get().asMap().orElseThrow()); + assertData(definition.instance().start().get().asMap().orElseThrow()); RecordedRequest openAPIRequest = openApiServer.takeRequest(); assertEquals("GET", openAPIRequest.getMethod()); - assertData(definition.instance(Map.of()).start().get().asMap().orElseThrow()); + assertData(definition.instance().start().get().asMap().orElseThrow()); openAPIRequest = openApiServer.takeRequest(); assertEquals("HEAD", openAPIRequest.getMethod()); } diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java index 3a14ceccf..29d487ac0 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java @@ -42,7 +42,7 @@ public void setTest() throws Exception { app.workflowDefinition(workflowChild); Map result = app.workflowDefinition(workflowParent) - .instance(Map.of()) + .instance() .start() .join() .asMap() @@ -63,7 +63,7 @@ public void setBlankInputTest() throws Exception { app.workflowDefinition(workflowChild); Map result = app.workflowDefinition(workflowParent) - .instance(Map.of()) + .instance() .start() .join() .asMap() @@ -153,7 +153,7 @@ public void runSubWorkflowFromDslTest() throws Exception { try (WorkflowApplication app = WorkflowApplication.builder().build()) { app.workflowDefinition(child); Map result = - app.workflowDefinition(parent).instance(Map.of()).start().join().asMap().orElseThrow(); + app.workflowDefinition(parent).instance().start().join().asMap().orElseThrow(); assertThat(result.get("counter"), is(equalTo(1))); assertThat(result.get("greeting"), is(equalTo("helloWorld"))); } @@ -181,7 +181,7 @@ public void runSubWorkflowsFromDslTest() throws Exception { app.workflowDefinition(child); app.workflowDefinition(update); Map result = - app.workflowDefinition(parent).instance(Map.of()).start().join().asMap().orElseThrow(); + app.workflowDefinition(parent).instance().start().join().asMap().orElseThrow(); assertThat(result.get("counter"), is(equalTo(2))); assertThat(result.get("greeting"), is(equalTo("helloWorld"))); } From 63577a042babacef42255a658ecd01df35d0b1b1 Mon Sep 17 00:00:00 2001 From: Matheus Cruz Date: Fri, 24 Apr 2026 14:03:21 -0300 Subject: [PATCH 3/3] Use spotless Signed-off-by: Matheus Cruz --- .../serverlessworkflow/impl/test/OpenAPITest.java | 8 +------- .../impl/test/SubWorkflowTest.java | 14 ++------------ 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java index 267117232..e7e9a3310 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/OpenAPITest.java @@ -194,13 +194,7 @@ public void testOpenAPIBearerQueryInlinedBodyWithNegativeResponse() throws Excep Exception exception = assertThrows( Exception.class, - () -> - app.workflowDefinition(workflow) - .instance() - .start() - .get() - .asMap() - .orElseThrow()); + () -> app.workflowDefinition(workflow).instance().start().get().asMap().orElseThrow()); assertInstanceOf(WorkflowException.class, exception.getCause()); assertTrue(exception.getMessage().contains("status=409")); diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java index 29d487ac0..380fb52dd 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java @@ -41,12 +41,7 @@ public void setTest() throws Exception { try (WorkflowApplication app = WorkflowApplication.builder().build()) { app.workflowDefinition(workflowChild); Map result = - app.workflowDefinition(workflowParent) - .instance() - .start() - .join() - .asMap() - .orElseThrow(); + app.workflowDefinition(workflowParent).instance().start().join().asMap().orElseThrow(); assertThat(result.get("counter"), is(equalTo(1))); assertThat(result.get("greeting"), is(equalTo("helloWorld"))); } @@ -62,12 +57,7 @@ public void setBlankInputTest() throws Exception { try (WorkflowApplication app = WorkflowApplication.builder().build()) { app.workflowDefinition(workflowChild); Map result = - app.workflowDefinition(workflowParent) - .instance() - .start() - .join() - .asMap() - .orElseThrow(); + app.workflowDefinition(workflowParent).instance().start().join().asMap().orElseThrow(); assertThat(result.get("counter"), is(equalTo(1))); assertThat(result.get("greeting"), is(equalTo("helloWorld"))); }