From 398882c1c96ee2ab2659e20806d676dbaebf87dc Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 7 May 2026 10:21:10 -0700 Subject: [PATCH 1/2] quic: remove unused binding variable in session.cc Signed-off-by: James M Snell --- src/quic/session.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/quic/session.cc b/src/quic/session.cc index b53bc291c20163..4af903e0c2a0af 100644 --- a/src/quic/session.cc +++ b/src/quic/session.cc @@ -1660,7 +1660,6 @@ Session::Session(Endpoint* endpoint, MakeWeak(); Debug(this, "Session created."); - auto& binding = BindingData::Get(env()); JS_DEFINE_READONLY_PROPERTY( env(), object, env()->stats_string(), impl_->stats_.GetArrayBuffer()); From 6e2ea3668ecf8fa001f28c75fcd130c319dac6c8 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 7 May 2026 10:24:31 -0700 Subject: [PATCH 2/2] quic: remove unused env_ variable in session_manager.h/cc Signed-off-by: James M Snell --- src/quic/bindingdata.cc | 2 +- src/quic/session_manager.cc | 4 ---- src/quic/session_manager.h | 6 ++---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/quic/bindingdata.cc b/src/quic/bindingdata.cc index 647808d5a1e6bf..4a3b3dba11f196 100644 --- a/src/quic/bindingdata.cc +++ b/src/quic/bindingdata.cc @@ -225,7 +225,7 @@ BindingData::BindingData(Realm* realm, Local object) SessionManager& BindingData::session_manager() { if (!session_manager_) { - session_manager_ = std::make_unique(env()); + session_manager_ = std::make_unique(); } return *session_manager_; } diff --git a/src/quic/session_manager.cc b/src/quic/session_manager.cc index 4345e726576e69..20f92bb74bb944 100644 --- a/src/quic/session_manager.cc +++ b/src/quic/session_manager.cc @@ -10,10 +10,6 @@ namespace node::quic { -SessionManager::SessionManager(Environment* env) : env_(env) {} - -SessionManager::~SessionManager() = default; - BaseObjectPtr SessionManager::FindSession(const CID& cid) { // Direct SCID match. auto it = sessions_.find(cid); diff --git a/src/quic/session_manager.h b/src/quic/session_manager.h index 760dc7e95415e9..0dfa47b41dd378 100644 --- a/src/quic/session_manager.h +++ b/src/quic/session_manager.h @@ -24,8 +24,8 @@ class Session; // It is not exposed to JavaScript. class SessionManager final { public: - explicit SessionManager(Environment* env); - ~SessionManager(); + explicit SessionManager() = default; + ~SessionManager() = default; // Session routing. The sessions_ map holds BaseObjectPtr (owning // references). SessionManager is the single authority for session ownership. @@ -78,8 +78,6 @@ class SessionManager final { bool is_empty() const; private: - Environment* env_; - // The sessions_ map holds strong owning references keyed by locally- // generated SCIDs. This is the single source of truth for session // ownership.