Allow reviewers to update task completion state from Review pane#2846
Draft
CollinBeczak wants to merge 1 commit into
Draft
Allow reviewers to update task completion state from Review pane#2846CollinBeczak wants to merge 1 commit into
CollinBeczak wants to merge 1 commit into
Conversation
Adds the Completion widget to the Review workspace defaults so reviewers
can correct a task's completion status without rerouting through the
mapper flow. The Completion widget renders ActiveTaskControls; when the
new asReviewer prop is set, the controls:
- dispatch the new updateTaskCompletionStatus action, which calls the
existing review-status endpoint with the current reviewStatus
preserved and newTaskStatus set, then stays on the current task
- use the "for revision" allowed-status progressions so reviewers see
valid status-change buttons even on Fixed/AlreadyFixed tasks
- hide the mapper-only Revision Complete / next-task / needs-review
/ load-by controls (in both the widget and the confirmation modal)
Meta-reviewers are unaffected — the action honors the existing
asMetaReview check from the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Completion widget to the Review workspace defaults so reviewers can correct a task's completion status without rerouting through the mapper flow. The Completion widget renders ActiveTaskControls; when the new asReviewer prop is set, the controls: