feat: added support for Podman as container engine#2548
Open
Linsner wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Jun 8, 2026
mcdurdin
left a comment
mcdurdin
left a comment
Member
There was a problem hiding this comment.
LGTM with the one small change to Dockerfile
| @@ -0,0 +1,39 @@ | |||
| # syntax=docker/dockerfile:1 | |||
|
|
|||
Member
There was a problem hiding this comment.
Suggested change
| # Please keep the content of this file in sync with Dockerfile. | |
And can we add the corresponding comment to Dockerfile also?
| COMPOSER_NO_DEV=1 composer install ; \ | ||
| fi | ||
|
|
||
| USER www-data |
Member
There was a problem hiding this comment.
This is above l.17 in Dockerfile (WORKDIR /composer). Is there a reason why it is here instead in Podmanfile?
Member
|
Test-bot: skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Podmanfile for the help site to the project repo.