clear escape delimiter buffer before peek in isEscapeDelimiter#608
Open
rootvector2 wants to merge 1 commit into
Open
clear escape delimiter buffer before peek in isEscapeDelimiter#608rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isEscapeDelimiter()peeks the next characters into the reusedescapeDelimiterBuflook-ahead without clearing it first, so a truncated escaped multi-character delimiter at EOF is completed from the stale bytes of an earlier full escaped delimiter and the lexer appends a delimiter the input never contained. clearing the buffer before the peek mirrors thedelimiterBufreset added innextTokenfor the plain multi-character delimiter path.found while reading the partial-delimiter-at-EOF fix (CSV-324): the escaped-delimiter sibling was left unguarded.
for delimiter
[|]and escape!, parsingx![!|!]y![!|returnsx[|]y[|]before the change and the correctx[|]y![!|after. regression tests added inLexerTestandCSVParserTest(both fail without the one-line change).mvn; that'smvnon the command line by itself.