From 819adaf71748616996ca95d159eb15b1e3b103d8 Mon Sep 17 00:00:00 2001 From: Anmol Saxena Date: Sun, 26 Apr 2026 05:58:37 +0530 Subject: [PATCH] fix(console): fix NPE in AbstractJmxCommand and AbstractCommand.handleException. --- .../activemq/console/command/AbstractCommand.java | 10 +++------- .../activemq/console/command/AbstractJmxCommand.java | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractCommand.java b/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractCommand.java index a55e04ead34..9abf52039cf 100644 --- a/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractCommand.java +++ b/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractCommand.java @@ -162,13 +162,9 @@ protected void printHelpFromFile() { } protected void handleException(Exception exception, String serviceUrl) throws Exception { - Throwable cause = exception.getCause(); - while (true) { - Throwable next = cause.getCause(); - if (next == null) { - break; - } - cause = next; + Throwable cause = exception; + while (cause.getCause() != null) { + cause = cause.getCause(); } if (cause instanceof ConnectException) { context.printInfo("Broker not available at: " + serviceUrl); diff --git a/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractJmxCommand.java b/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractJmxCommand.java index 97e508450a0..6a84b569aa5 100644 --- a/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractJmxCommand.java +++ b/activemq-console/src/main/java/org/apache/activemq/console/command/AbstractJmxCommand.java @@ -388,7 +388,7 @@ public void execute(List tokens) throws Exception { try { super.execute(tokens); } catch (Exception exception) { - handleException(exception, jmxServiceUrl.toString()); + handleException(exception, jmxServiceUrl != null ? jmxServiceUrl.toString() : "local"); return; }finally { closeJmxConnection();