Sable makes malformed space children events

[cyrneko]

Describe the bug

Rooms added through Sable will not properly appear to anyone that isn't already in the room.

Reproduction

1. Create a space
2. Add some rooms
3. Invite someone to the space
4. Other user cannot properly browse / see / join the rooms (exact details depend on client)

Expected behavior

No response

Platform and versions

- OS: Linux x86_64
- Browser: Mozilla/5.0 (X11; Linux x86_64; rv:140.0) Gecko/20100101 Firefox/140.0
- Sable: v1.15.2 (1c46081)

Additional context

I need to further investigate, but simply removing all rooms from the space and re-adding them with Element X resolved the issue.

[7w1]

I can't seem to reproduce anything specific, just did some basic testing with element web. The actual room data seems normal to me so not sure what the issue could be.

JSON m.space.child events from a few clients

A room added to a space from Sable:

{
  "content": {
    "auto_join": false,
    "suggested": false,
    "via": [
      "sable.moe"
    ]
  },
  "event_id": "$j8JqrxUFBYm3ykaO_MK7ogvRi94bvVRCkGVdbD5lZmg",
  "origin_server_ts": 1778264526743,
  "sender": "@seven:sable.moe",
  "state_key": "!ILh1573wEoGMeBRdt_lvfuF-6UZntdLebiZq7uV4cS0",
  "type": "m.space.child",
  "unsigned": {
    "age": 424966
  },
  "room_id": "!I2YD4DBWv4s07gk-96cNoxr4Y6urRt3OHKE9wNKJ_6Q"
}

A room added to a space from Element Web

{
  "content": {
    "suggested": false,
    "via": [
      "sable.moe"
    ]
  },
  "event_id": "$yT1DpWeGe_yhE_8GG_6XZmuIpTJBozxL-n9PyM7V_bE",
  "origin_server_ts": 1778264407636,
  "sender": "@seven:sable.moe",
  "state_key": "!-k-r-Z4m-MplJVc48RMUCt0SfnnUfzoL30RcqEoIq4Q",
  "type": "m.space.child",
  "unsigned": {
    "age": 37
  },
  "room_id": "!m_wMKxZDcjsBHxvAtlwkaoX9n4MWEHm4noeroj9womE"
}

Edit: And here's Cinny:

{
  "content": {
    "auto_join": false,
    "suggested": false,
    "via": [
      "sable.moe"
    ]
  },
  "event_id": "$oUMLsM00xPlj1-Sce3DpPoedgE8GSBfyD1JJgdDDTZI",
  "origin_server_ts": 1778265351030,
  "sender": "@seven:sable.moe",
  "state_key": "!CMt9EMXUo9_106-4w7mT9KL5kZJdRt6eWubhCnEcm4U",
  "type": "m.space.child",
  "unsigned": {
    "age": 28
  },
  "room_id": "!m_wMKxZDcjsBHxvAtlwkaoX9n4MWEHm4noeroj9womE"
}

Edit edit: Commets:

{
  "content": {
    "via": [
      "sable.moe"
    ]
  },
  "event_id": "$dSojS0EBNy9KDMEvQwk5kWWgD-w9oqbnJCDno3iaafM",
  "origin_server_ts": 1778265623310,
  "sender": "@seven:sable.moe",
  "state_key": "!eyY5UggbZ5vV191sDvHks_wqq8q8gDw-WvGRV10AK8g",
  "type": "m.space.child",
  "unsigned": {
    "age": 7
  },
  "room_id": "!I2YD4DBWv4s07gk-96cNoxr4Y6urRt3OHKE9wNKJ_6Q"
}

I don't see any differences there that matter at all?

[cyrneko]

that is interesting

to give some more info about the scenario, I had created and configured a space entirely within Sable, including setting suggested rooms, the order, etc, and depending on the client some breakages happened as compared to setting these through other clients (SchildiNext, Commet):

• Fluffychat:
  • shows "4 Chats" on the overview, upon entering the space no rooms are listed
• Sable & Cinny:
  • Starts loading 4 rooms before showing an "Inaccessible" placeholder

So, considering how this was only reproducible with sable being who does the adding, reordering and such I had concluded it must be something in the structure of the state-event...perhaps try changing the order? I know that's a field which is missing entirely from the above JSON.