From b2e0f164b679e8ebd6096492ae6cc221b690296e Mon Sep 17 00:00:00 2001 From: Erik van Sebille Date: Fri, 17 Apr 2026 10:40:25 +0200 Subject: [PATCH 1/2] Fix interpolation error in MOI benchmark The interpolation error was due to the particle.z not explicitly set, meaning that particles were released at z=0; which is out of the domain? --- benchmarks/moi_curvilinear.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/benchmarks/moi_curvilinear.py b/benchmarks/moi_curvilinear.py index d5a559f..2e278ba 100644 --- a/benchmarks/moi_curvilinear.py +++ b/benchmarks/moi_curvilinear.py @@ -65,8 +65,9 @@ def pset_execute_3d(self, interpolator, chunk, npart): lon = np.linspace(-10, 10, npart) lat = np.linspace(-30, -20, npart) + z= np.ones(npart) * 10 # 10 m depth - pset = parcels.ParticleSet(fieldset=fieldset, pclass=pclass, lon=lon, lat=lat) + pset = parcels.ParticleSet(fieldset=fieldset, pclass=pclass, lon=lon, lat=lat, z=z) pset.execute( parcels.kernels.AdvectionEE, runtime=runtime, dt=dt, verbose_progress=False From 685be4617b8bbadfa9f5c3494ed82e9f0f65e397 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 17 Apr 2026 08:40:43 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- benchmarks/moi_curvilinear.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/benchmarks/moi_curvilinear.py b/benchmarks/moi_curvilinear.py index 2e278ba..6f8e1b1 100644 --- a/benchmarks/moi_curvilinear.py +++ b/benchmarks/moi_curvilinear.py @@ -65,9 +65,11 @@ def pset_execute_3d(self, interpolator, chunk, npart): lon = np.linspace(-10, 10, npart) lat = np.linspace(-30, -20, npart) - z= np.ones(npart) * 10 # 10 m depth + z = np.ones(npart) * 10 # 10 m depth - pset = parcels.ParticleSet(fieldset=fieldset, pclass=pclass, lon=lon, lat=lat, z=z) + pset = parcels.ParticleSet( + fieldset=fieldset, pclass=pclass, lon=lon, lat=lat, z=z + ) pset.execute( parcels.kernels.AdvectionEE, runtime=runtime, dt=dt, verbose_progress=False