From bde6d162ba52650a2b6ed0b59dc0c1fed6d35875 Mon Sep 17 00:00:00 2001
From: LeanBitLab <245915690+LeanBitLab@users.noreply.github.com>
Date: Mon, 27 Apr 2026 20:35:44 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=92=20Fix:=20use=20ProcessBuilder=20fo?=
 =?UTF-8?q?r=20logcat=20shell=20execution?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Migrates `Runtime.getRuntime().exec` to `ProcessBuilder` with array args in AboutScreen to avoid relying on unsafe string tokenization for command execution.
---
 .../java/helium314/keyboard/settings/screens/AboutScreen.kt     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt b/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt
index 26c19b1e0..8bb14379b 100644
--- a/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt
+++ b/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt
@@ -169,7 +169,7 @@ fun createAboutSettings(context: Context) = listOf(
             scope.launch(Dispatchers.IO) {
                 ctx.getActivity()?.contentResolver?.openOutputStream(uri)?.use { os ->
                     os.writer().use { writer ->
-                        val logcat = Runtime.getRuntime().exec("logcat -d -b all *:W").inputStream.use { it.reader().readText() }
+                        val logcat = ProcessBuilder("logcat", "-d", "-b", "all", "*:W").start().inputStream.use { it.reader().readText() }
                         val internal = Log.getLog().joinToString("\n")
                         writer.write(logcat + "\n\n" + internal)
                     }