Skip to content

UID2-7002 Use 'publish-major' env instead of hardcoded approver list #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swibi-ttd merged 2 commits into from
May 14, 2026
Merged

UID2-7002 Use 'publish-major' env instead of hardcoded approver list #2542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b4446
use 'publish-major' env instead of hardcoded approver list
swibi-ttd May 14, 2026
c76df94
only print Major release approved when it's actually a Major release
swibi-ttd May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/publish-all-operators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,16 @@
- cron: "0 0 * * *"

jobs:
check_major:
name: Check if major release
runs-on: ubuntu-latest
environment: ${{ inputs.release_type == 'Major' && 'publish-major' || '' }}
steps:
- run: echo "${{ inputs.release_type == 'Major' && 'Major release approved' || 'Skipped - not a Major release' }}"

start:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
name: Start Operator Build
needs: check_major
runs-on: ubuntu-latest
environment: ${{ github.ref_protected && 'ci-auto-merge' || '' }}
outputs:
Expand All @@ -42,15 +50,6 @@
echo "vulnerability_severity=${{ inputs.vulnerability_severity || (github.event_name == 'schedule' && 'CRITICAL,HIGH') }}" >> $GITHUB_ENV
echo "release_type=${RELEASE_TYPE}" >> $GITHUB_OUTPUT
echo "vulnerability_severity=${VULNERABILITY_SEVERITY}" >> $GITHUB_OUTPUT
- name: Approve Major release
if: env.RELEASE_TYPE == 'Major'
uses: trstringer/manual-approval@74d99dff7380e3e4b122d4ededcbca2b6ce59367 # v1
with:
secret: ${{ github.token }}
approvers: atarassov-ttd,vishalegbert-ttd,sunnywu,clarkxuyang
minimum-approvals: 1
issue-title: Creating Major version of UID2-Operator

- name: Show Context
run: |
printenv
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/publish-public-operator-docker-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,9 @@ jobs:
check_major:
name: Check if major release
runs-on: ubuntu-latest
environment: ${{ inputs.release_type == 'Major' && 'publish-major' || '' }}
steps:
- name: Approve Major release
if: inputs.release_type == 'Major'
uses: trstringer/manual-approval@74d99dff7380e3e4b122d4ededcbca2b6ce59367 # v1
with:
secret: ${{ github.token }}
approvers: atarassov-ttd,vishalegbert-ttd,sunnywu,clarkxuyang
minimum-approvals: 1
issue-title: Creating Major version of UID2-Operator
- run: echo "${{ inputs.release_type == 'Major' && 'Major release approved' || 'Skipped - not a Major release' }}"

image:
name: Image
Expand Down
Loading