UID2-7002 Use 'publish-major' env instead of hardcoded approver list#2542
Merged
Conversation
swibi-ttd
changed the title
swibi-ttd
force-pushed
the
swi-UID2-6763-publish-major-env
branch
from
5118015 to
10b4446
Compare
| runs-on: ubuntu-latest | ||
| environment: ${{ inputs.release_type == 'Major' && 'publish-major' || '' }} | ||
| steps: | ||
| - run: echo "Major release approved" |
Contributor
There was a problem hiding this comment.
I think this will always print "Major release approved" even if its not a major release, maybe make this step conditional on whether its a major release?
Contributor
Author
There was a problem hiding this comment.
good catch, would have been scary to see that if intention was a Patch release lol
have updated to only print that on a Major release
BehnamMozafari
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
trstringer/manual-approvalsteps in bothpublish-all-operators.yamlandpublish-public-operator-docker-image.yamlwith env-gatedcheck_majorjobs using the newpublish-majorenvironment.Behaviour preserved:
publish-all-operators.yaml→ 2 approval prompts (parent + leaf), same as beforepublish-public-operator-docker-image.yaml→ 1 prompt (leaf)