[Bug]: Missing `#include <cstdint>`

[eschnett]

Contact Details

No response

What happened?

I encounter a build error in the file examples/core/core_compress.cpp. The symbol PRIu64 is undefined. This patch remedies this for me:

--- a/examples/core/core_compress.cpp
+++ b/examples/core/core_compress.cpp
@@ -31,6 +31,7 @@
 #include <memory>
 #include <cstdlib>
 #include <inttypes.h>
+#include <cstdint>
 
 #include "grok.h"
 #include "core.h"

Version

20.3.2

Operating System

Linux

Relevant log output

[eschnett]

Apologies, that patch is not working.

[eschnett]

To remedy this and other errors, I need to run these commands

# Use proper C++ include headers
find examples -type f \( -name '*.h' -o -name '*.cpp' \) -exec sed -i 's/#include <inttypes\.h>/#include <cinttypes>/g' {} +

# Correct case of file name
find src -type f \( -name '*.h' -o -name '*.cpp' \) -exec sed -i 's/#include <Windows\.h>/#include <windows.h>/g' {} +

# Fix namespace location of `aligned_alloc` on Apple
if [[ ${target} == *-apple-* ]]; then
    find src -type f \( -name '*.h' -o -name '*.cpp' \) -exec sed -i 's/std::aligned_alloc/::aligned_alloc/g' {} +
fi

and apply this patch

--- a/src/lib/codec/apps/GrkCompress.cpp
+++ b/src/lib/codec/apps/GrkCompress.cpp
@@ -22,6 +22,7 @@
 #include <cstddef>
 #include <cstdlib>
 #include <sstream>
+#include <cinttypes>
 #ifndef _WIN32
 #include <cstring>
 #include <sys/time.h>
xxx
--- a/src/lib/codec/apps/GrkDecompress.cpp
+++ b/src/lib/codec/apps/GrkDecompress.cpp
@@ -16,6 +16,7 @@
  */
 
 #include <filesystem>
+#include <cinttypes>
 #ifndef _WIN32
 #include <sys/time.h>
 #include <sys/resource.h>

[boxerab]

What is the exact type of operating system and version that you are running?

[eschnett]

i am building grok 20.3.2. i am cross building on x86_64-linux-musl and targeting various other architectures and operating systems.

• the Windows.h error appears when cross-building for mingw32. The problem is that I am building on a case-sensitive file system, and mingw ships a file with a lower-case file name windows.h.
• the Apple error appears when cross-building for Apple, using a modern MacOS SDK.
• the other errors appear when using modern GCC or Clang versions.

[boxerab]

@eschnett master should now have these changes. Closing - please re-open if you are still having issues.