From 192cd4357f32ac7fae1ab844877ca3c009116085 Mon Sep 17 00:00:00 2001
From: "Arthur C." <maxandmin2021@gmail.com>
Date: Tue, 5 May 2026 22:04:24 +0100
Subject: [PATCH 1/4] Add form elements for user input 2

---
 Form-Controls/index.html | 38 ++++++++++++++++++++++++++++++++++----
 1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 74b591ffc..d0160a302 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -13,10 +13,40 @@ <h1>Product Pick</h1>
     </header>
     <main>
       <form>
-        <!-- write your html here-->
-        <!-- 
-          try writing out the requirements first as comments
-        this will also help you fill in your PR message later-->
+     <label for="user-name">Your Name:</label>
+<input id="user-name", type="text", pattern="[A-Za-z\s]{2,}" 
+title="Please enter at least 2 letters. Numbers and symbols are not allowed"       
+required> </input>
+
+<br>
+
+<label for="email">Your Email:</label>
+<input id="email" type="email" required>  </input>
+<button id="go"> Go
+</button>
+
+<br>
+
+<label for="colors">Choose your favorite color:</label>
+<select id="colors" name="colour" required>
+  <option value="" disabled selected>Select a color...</option>
+  <option value="red">Red</option>
+  <option value="blue">Blue</option>
+  <option value="green">Green</option>
+</select>
+
+<br>
+
+<label for="shirtsize">What size do you want?</label>
+
+<select id="shirtsize" name="size" required>
+  <option value="" disabled selected>Select a size...</option>
+  <option value="red">S</option>
+  <option value="blue">M</option>
+  <option value="green">L</option>
+  <option value="green">XL</option>
+  <option value="green">XXL</option>
+</select>
       </form>
     </main>
     <footer>

From 66791a0245faf62a39e0377b1c4c48e1088fbb26 Mon Sep 17 00:00:00 2001
From: "Arthur C." <maxandmin2021@gmail.com>
Date: Wed, 6 May 2026 11:15:19 +0100
Subject: [PATCH 2/4] Fix HTML structure and update meta tags

---
 Form-Controls/index.html | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index d0160a302..46458a3de 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -1,11 +1,11 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
-    <meta charset="utf-8" />
-    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta charset="utf-8">
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <title>My form exercise</title>
-    <meta name="description" content="" />
-    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <meta name="description" content="">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
   </head>
   <body>
     <header>
@@ -14,14 +14,13 @@ <h1>Product Pick</h1>
     <main>
       <form>
      <label for="user-name">Your Name:</label>
-<input id="user-name", type="text", pattern="[A-Za-z\s]{2,}" 
-title="Please enter at least 2 letters. Numbers and symbols are not allowed"       
-required> </input>
+<input id="user-name", type="text", pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> 
+
 
 <br>
 
 <label for="email">Your Email:</label>
-<input id="email" type="email" required>  </input>
+<input id="email" type="email" required>
 <button id="go"> Go
 </button>
 

From c955206a248609411f362fe7c2498dc366541ff1 Mon Sep 17 00:00:00 2001
From: "Arthur C." <maxandmin2021@gmail.com>
Date: Wed, 6 May 2026 11:33:00 +0100
Subject: [PATCH 3/4] Fix input tag formatting in index.html

---
 Form-Controls/index.html | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 46458a3de..518026942 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -14,7 +14,7 @@ <h1>Product Pick</h1>
     <main>
       <form>
      <label for="user-name">Your Name:</label>
-<input id="user-name", type="text", pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> 
+<input id="user-name" type="text" pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> 
 
 
 <br>
@@ -53,4 +53,10 @@ <h1>Product Pick</h1>
       <p>By HOMEWORK SOLUTION</p>
     </footer>
   </body>
+</html>
+    <footer>
+      <!-- change to your name-->
+      <p>By HOMEWORK SOLUTION</p>
+    </footer>
+  </body>
 </html>

From ff8f2b9161bccce16f614e444dd6846528b59858 Mon Sep 17 00:00:00 2001
From: "Arthur C." <maxandmin2021@gmail.com>
Date: Wed, 13 May 2026 12:40:50 +0100
Subject: [PATCH 4/4] Correction after review

---
 Form-Controls/index.html | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 518026942..3742c98c8 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -14,14 +14,23 @@ <h1>Product Pick</h1>
     <main>
       <form>
      <label for="user-name">Your Name:</label>
-<input id="user-name" type="text" pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> 
+<input id="user-name" type="text" pattern="[A-Za-z\s\-]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> 
 
 
 <br>
 
 <label for="email">Your Email:</label>
-<input id="email" type="email" required>
-<button id="go"> Go
+<input id="email" name="user_email" type="email" required>
+<button id="go" type="submit"> GoWeiTsungCheng19 hours ago
+You should put your name here
+
+WeiTsungCheng19 hours ago
+This is incorrectly expressed.
+
+Besides some duplicate values, the value of size should not be color.
+
+WeiTsungCheng19 hours ago
+It's best to include a name in the input field. Or the form won't include the data when you submit it
 </button>
 
 <br>
@@ -40,11 +49,11 @@ <h1>Product Pick</h1>
 
 <select id="shirtsize" name="size" required>
   <option value="" disabled selected>Select a size...</option>
-  <option value="red">S</option>
-  <option value="blue">M</option>
-  <option value="green">L</option>
-  <option value="green">XL</option>
-  <option value="green">XXL</option>
+  <option value="s">S</option>
+  <option value="m">M</option>
+  <option value="l">L</option>
+  <option value="xl">XL</option>
+  <option value="xxl">XXL</option>
 </select>
       </form>
     </main>
@@ -56,7 +65,7 @@ <h1>Product Pick</h1>
 </html>
     <footer>
       <!-- change to your name-->
-      <p>By HOMEWORK SOLUTION</p>
+      <p>Chan Yat Long</p>
     </footer>
   </body>
 </html>
