Skip to content

Use process.env after fixing it#26

Merged
rmccue merged 1 commit into
masterfrom
use-path-after-fix
Jul 15, 2017
Merged

Use process.env after fixing it#26
rmccue merged 1 commit into
masterfrom
use-path-after-fix

Conversation

@rmccue

@rmccue rmccue commented Jul 14, 2017

Copy link
Copy Markdown
Contributor

Previously, we were using process.env from when the module loaded. This caused it to miss out on the fixPath corrections. See #18 for previous fix, and discussion.

Previously, we were using process.env from when the module loaded. This
caused it to miss out on the fixPath corrections.
@rmccue

rmccue commented Jul 14, 2017

Copy link
Copy Markdown
Contributor Author

@jonathan-dejong Can you test http://make.hmn.md/chassis/Chassis%20Desktop-0.2.1-pr26.dmg and see if it fixes your issue from #18? :)

@jonathan-dejong

Copy link
Copy Markdown

Sure! Do I need to do a complete uninstall of prev version first?

@rmccue

rmccue commented Jul 14, 2017

Copy link
Copy Markdown
Contributor Author

Shouldn't need to, just drop the app over the top of your existing one to replace it.

@jonathan-dejong

Copy link
Copy Markdown

skarmavbild 2017-07-14 kl 08 49 52

Looks promising :)

@jonathan-dejong

Copy link
Copy Markdown

Yep it now works :)

A slightly unrelated question for you:
If I wanted to add extensions etc. to chassis to make it play better with our own custom workflow, I can't use the app?

@rmccue

rmccue commented Jul 15, 2017

Copy link
Copy Markdown
Contributor Author

If I wanted to add extensions etc. to chassis to make it play better with our own custom workflow, I can't use the app?

Under the hood, Desktop is still using a full Chassis Box, so you can add extensions like you normally would. UI for adding extensions is coming soon: #11.

@rmccue

rmccue commented Jul 15, 2017

Copy link
Copy Markdown
Contributor Author

And thanks for testing! Full release with this bug fix coming soon.

@rmccue rmccue merged commit 0354efa into master Jul 15, 2017
@rmccue rmccue deleted the use-path-after-fix branch July 15, 2017 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants